Closed thafryer closed 6 months ago
@thafryer
AP-4088, AP-4135, AP-4189 - At this point, the user is no longer required to set an origin. They still need to initialize the Git repo and commit at least one. AP-4093 - If a user runs a project in a repo that does not have a chromatic script in their package.json, this interactive prompt will no longer appear in the CLI console.
Are these two changes in the CLI? Are they part of this PR just via bumping the version?
In general, it would be better to have multiple PRs if different things are happening, IMO.
@thafryer
AP-4088, AP-4135, AP-4189 - At this point, the user is no longer required to set an origin. They still need to initialize the Git repo and commit at least one. AP-4093 - If a user runs a project in a repo that does not have a chromatic script in their package.json, this interactive prompt will no longer appear in the CLI console.
Are these two changes in the CLI? Are they part of this PR just via bumping the version?
In general, it would be better to have multiple PRs if different things are happening, IMO.
Yes! AP-4088, AP-4135, and AP-4189 are resolved by bumping the CLI version and adjusting copy within the addon. AP-4093 is resolved by setting the interactive option to false when we kick off the builds.
These changes were small and where I started before adding the additional remove/uninstall workflows. I kept moving ahead since this PR was still pretty small with the noted changes..
Fixes AP-4093, AP-4088, AP-4129, AP-4130, AP-4135, AP-4189
This PR seeks to resolve issues resulting from QA and feedback.
AP-4130, AP-4189 - This adds an option to remove the addon via the footer menu and from the "Git Not Detected" Screen.
📦 Published PR as canary version:
1.0.5--canary.172.9d48858.0
:sparkles: Test out this PR locally via: ```bash npm install @chromatic-com/storybook@1.0.5--canary.172.9d48858.0 # or yarn add @chromatic-com/storybook@1.0.5--canary.172.9d48858.0 ```