search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
31 stars 2 forks source link

Adjust Status Visibility on Mode & Browser Selectors #173

Closed thafryer closed 6 months ago

thafryer commented 6 months ago

We should only show the status dot for the Mode and Browser selectors when there is more than one browser or mode.

To test

  1. View the Browser Selector and Mode Selector Stories.
  2. Run a build with multiple browsers enabled. You should see status dots on errors or changes on the Browser Selector.
  3. Run a build with a story that has multiple modes. You should see status dots on errors or changes on the Modes Selector.
  4. Run a build with a single browser enabled. You should not see status dots on errors or changes on the Browser Selector.
  5. Run a build with a story with a single mode enabled. You should not see status dots on errors or changes on the Modes Selector.

Note: I also updated the readme to remove config info and point people at the hosted docs.

andrewortwein commented 6 months ago

Code looks good, finishing up on testing now

domyen commented 6 months ago

lgtm