search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Fix kebab-case `box-shadow` to proper `boxShadow` #181

Closed JReinhold closed 8 months ago

JReinhold commented 8 months ago

There's currently an error in the console of any Storybook with VTA about using box-shadow while only boxShadow is allowed:

image

The kebab-cased style won't be applied so the warning is valid.

This was probably an oversight during the hectic transformation of CSS styles to JS object styles at https://github.com/chromaui/addon-visual-tests/commit/76466a58b444a16906317ce5e7493c3926cc4ad0#diff-6670cf4c6d5074d9ed37d761697fbbc372e5aa961f0907c7b305a1bd7f1e0e2aR118

JReinhold commented 8 months ago

I just noticed that the hoverEffect is not used anywhere, so it could also be valid to remove the whole object completely. Up to you.