search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
30 stars 1 forks source link

Show error when build is limited (account is out of snapshots) #194

Closed ghengeveld closed 4 months ago

ghengeveld commented 4 months ago

Rather than hanging the build at the Verify step, fail the build with an error and link to the Billing screen.

I did not bother designing this to be any fancier than the default error message we already had.

Screenshot 2024-03-05 at 10 50 38 Screenshot 2024-03-05 at 10 50 44
📦 Published PR as canary version: 1.2.8--canary.194.78d37d8.0
:sparkles: Test out this PR locally via: ```bash npm install @chromatic-com/storybook@1.2.8--canary.194.78d37d8.0 # or yarn add @chromatic-com/storybook@1.2.8--canary.194.78d37d8.0 ```
domyen commented 4 months ago

@MichaelArestad did you have an error state for this?

MichaelArestad commented 4 months ago

@domyen Yes. All the error states can be found here. For this use case, these two are the most relevant:

image
andrewortwein commented 4 months ago

Code changes look fine to me, but should we try to implement the error state designs above?

domyen commented 4 months ago

I think we should try to implement the error state because it associates the blocker with "upgrading plan".