chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Prevent flashing wrong screen by increasing timeout #195

Closed ghengeveld closed 7 months ago

ghengeveld commented 7 months ago

We already had a timeout in place to prevent flashing the wrong screen, but it wasn't long enough. Extending it to 10 seconds ensures we only reset the uncommittedHash while the new build is underway, thereby preventing the wrong screen from appearing. Arguably this is not the most reliable solution but a proper fix would be way more involved and this is likely good enough.

📦 Published PR as canary version: 1.2.4--canary.195.ca78be3.0
:sparkles: Test out this PR locally via: ```bash npm install @chromatic-com/storybook@1.2.4--canary.195.ca78be3.0 # or yarn add @chromatic-com/storybook@1.2.4--canary.195.ca78be3.0 ```