chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
28 stars 1 forks source link

Issue with running the addon with UI Tests and UI Review disabled #230

Closed ghengeveld closed 1 month ago

ghengeveld commented 3 months ago

From AP-3682

During some testing, I noticed that running the addon with the settings we currently provide to our customers (i.e., UI review and UI testing) disabled can lead to misconceptions from our users despite our best efforts to provide the necessary mechanisms and UX to match their expectations.

The most critical point is when a customer, for any reason above our control, disables UI Review and UI Tests, runs Storybook with the addon configured, and tries to run tests on their components, which leaves it in an inconsistent and incorrect state as the setting is disabled in their project.

For more context, see the discussion linked in the Linear ticket (i.e, AP-3682)

Looking forward to hearing everyone's thoughts on this so we can have a clear path moving forward.

MichaelArestad commented 3 months ago

There are a few more comments in the original ticket, but this is the key one:

Proposal

We'd need to create an error message for this scenario and then apply our existing template. The turnaround can be quite fast. Design 👇

image

We will send them to the web app to reenable tests.