search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
37 stars 2 forks source link

Sidebar with changes & accepting snapshots #236

Open ghengeveld opened 8 months ago

ghengeveld commented 8 months ago

From AP-4223

How is the user affected? And what is the expected behavior?

I have the changes filter on for the sidebar. I accept a change in VTA.

When I accept the change, I do not expect the currently highlighted item to disappear immediately because that makes me wonder which story I'm viewing. I expect it to no longer have the yellow badge and persist in the sidebar until I go to another change in the sidebar.

2024-02-08 17 16 43

MichaelArestad commented 8 months ago

Comments from original ticket:

Might require help from Storybook team to make sure that we do not filter the item out until we change to another story. via @thafryer

I think this boils down to "always show currently selected story even if it doesn't match the filter". via @ghengeveld