chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
28 stars 1 forks source link

Onboarding shows wrong screen #246

Closed ghengeveld closed 3 months ago

ghengeveld commented 3 months ago

From AP-4342

How is the user affected? And what is the expected behavior?

After running my first build in a fresh project as part of the "happy path" onboarding (Storybook 8.0.0-rc.2, VTA 1.2.7, I see the following screen:

image

The contents of the addon panel look wrong to me. I would expect it to say something to the effect of "congrats on running your first build, now let's check out the changes. Next >".

When I click the "Done" button, it takes me to the next step of the tour--which is blocked by the "Storybook 8 enters beta" notification. A separate bug, I think.

How many and/or what class of users does this impact?

All VTA users? I'm not sure.

Is there a workaround?

Yes, if you click "Done" it will take you to the next step of the tour.

What are the steps for reproducing the issue?

To get to this step, I:

  1. Created an empty directory
  2. Ran npx storybook@nextinit in the directory and selected react-vite-ts option
  3. Set up git
  4. Ran through the onboarding
  5. Changed the story text of the Button.Secondary story to "Buttoon"
  6. Ran my first build
MichaelArestad commented 3 months ago

This is how that view should look. The copy needs to be updated:

image

It looks like the design you are seeing in the issue above should only be visible to users who already completed onboarding once.

shilman commented 3 months ago

Possible duplicate to #252 ?

ghengeveld commented 3 months ago

@MichaelArestad This looks like you're not in the onboarding state (you skipped/finished the walkthrough already). The vtaOnboarding query param may not be sufficient. You can reset it through the API like so:

mutation {
  updateUserPreferences(input: { vtaOnboarding: UNSET }) {
    updatedPreferences {
      vtaOnboarding
    }
  }
}
MichaelArestad commented 3 months ago

@ghengeveld Does that mean our users won't see the wrong screen during setup?

ghengeveld commented 3 months ago

I'll check again but I think I've seen that screen for which you shared the design.

ghengeveld commented 3 months ago

I just verified, this is what I see on a clean project after running the first build:

Screenshot 2024-04-04 at 17 42 20

This looks like the correct screen to me. This is the next step:

Screenshot 2024-04-04 at 17 43 45
ghengeveld commented 3 months ago

I opened #283 to fix the background color on the thumbnail container (the image should be on a white background, not transparent).