search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
28 stars 1 forks source link

Locally accepted baselines not carried over when switching branch #249

Open ghengeveld opened 3 months ago

ghengeveld commented 3 months ago

From AP-4356

How is the user affected? And what is the expected behavior?

Locally accepted snapshots are supposed to be promoted to project-wide baselines when the local author pushes a commit that runs a CI build. However, when the local builds ran on a different branch, those accepted changes don't carry over and need to be reviewed again.

How many and/or what class of users does this impact?

Users that make local changes, accept VTA builds and then switch branch before committing.

Is there a workaround?

Switch branch before running any local VTA builds.

What are the steps for reproducing the issue?

On main, make some visual changes, run some builds and accept the changes locally. Create a new branch and commit your work. Push the changes to trigger a CI build. This build will resurface all changes that were previously accepted on the local build.

ghengeveld commented 1 month ago

This is related to, but not the same as #259.