chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
28 stars 1 forks source link

UI - Misleading information for non authenticated or expired auth tokens #250

Open ghengeveld opened 3 months ago

ghengeveld commented 3 months ago

From AP-4360

How is the user affected? And what is the expected behavior?

When a user enables the Visual tests addon as part of their Storybook setup and tries to open a new browser in which he's not authenticated or the auth token has expired, the user is presented with the following UI:

Non-UI-expired-token

This feels like a regression, and the messaging needs to be clarified as the user has a project setup, including the configuration file. To which the user should be instructed to authenticate and not switch to a different account as the message suggests.

Additionally, the "Configuration should be improved" message bar, should be removed, more even as the user already has the project set up and the configuration file in place which can lead to confusion from the user as he's not sure what to do next or what the message is referring to.

How many and/or what class of users does this impact?

All

What are the steps for reproducing the issue?

MichaelArestad commented 3 months ago
  1. I think we should have two links. One, a button, should say "Reauthenticate", and the second a link, "Switch account". We don't want to indicate if a project exists or not in CH.

  2. That "Configuration should be improved" message is showing up often at the wrong time/place. We should have a discussion to work out when to show it in another issues.