chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Fix misbehaving in rendering when addon is not active #272

Closed yannbf closed 6 months ago

yannbf commented 6 months ago

The addon was rendering even when it was not supposed to, as can be seen here:

image

The Storybook addon API contains a flag to indicate whether the addon is actively selected, so we use it in order to not render it when not needed

CAVEAT

There is a side effect where the addon is not rendering instantly as before when switching tabs. It displays a spinner. We should check how to find a middle ground for this

📦 Published PR as canary version: 1.2.27--canary.272.30610d6.0
:sparkles: Test out this PR locally via: ```bash npm install @chromatic-com/storybook@1.2.27--canary.272.30610d6.0 # or yarn add @chromatic-com/storybook@1.2.27--canary.272.30610d6.0 ```