MichaelArestad
commented
2 months ago I found maybe a couple issues. It's a little easier to show so here's a quick video:
https://github.com/chromaui/addon-visual-tests/assets/1123119/95bb232e-e029-409b-b14f-cc7c4d461b3b
Summary of bugs:
- Once changes are found, I should be immediately put in the guided tour.
- "No changes found..." message isn't quite right, but it wouldn't be visible if we put the user into the guided tour.
Other than this, the PR looks good to me!
Fixes #279
This includes a bunch of fixes and refactorings for the onboarding logic as well. Specifically, the 2nd "catch a change" build for onboarding will now be skipped if the currently selected story already had a change on the 1st build (e.g. when onboarding an existing Chromatic project). Inversely, if you switch to a story that doesn't have visual changes then you'll be prompted to "catch a change" again. Previously we would only consider the build as a whole, now it's story-specific which better fits the onboarding narrative ("make a change to this story").
📦 Published PR as canary version:
1.3.2--canary.287.94a84c4.0:sparkles: Test out this PR locally via: ```bash npm install @chromatic-com/storybook@1.3.2--canary.287.94a84c4.0 # or yarn add @chromatic-com/storybook@1.3.2--canary.287.94a84c4.0 ```