chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
28 stars 1 forks source link

Stories with `parameters.chromatic.disable: true` show "New story found" #294

Closed ghengeveld closed 1 month ago

ghengeveld commented 2 months ago

Describe the bug

Stories where Chromatic is explicitly disabled will always show the "New story found" screen. Running a build will not snapshot it and thus continue to show this screen. There should be an explanation that the current story is disabled for Chromatic.

To reproduce

Create a story like this:

export const ChromaticDisabled = {
  parameters: {
    chromatic: { disable: true }
  }
}

Open the Visual Tests panel on this story, it will show this screen:

Screenshot 2024-04-28 at 12 28 35

Run a build and confirm it continues to show this screen.

Environment

Storybook v8.0.9 for Next.js. Visual Tests addon v1.3.3.

shilman commented 1 month ago

@ghengeveld Not critical but pretty annoying! We should fix during cooldown if possible.