chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
36 stars 2 forks source link

Send mainPath and configDir on update success/failure #53

Closed tmeasday closed 1 year ago

tmeasday commented 1 year ago

Telescoping on https://github.com/chromaui/addon-visual-tests/pull/41

Send the main.js location and configDir up on success/failure so we can incorporate it into the UIs.

To QA:

  1. Clear the selected options from main.ts: https://github.com/chromaui/addon-visual-tests/blob/1f7b002a58d160c755bb363e686b62cc64de9c42/.storybook/main.ts#L40

  2. Make findConfig error, select a project, check you see generic instructions (no specific main location)

  3. Make updateMain error, select a project, check you see instructions that include main.ts

  4. Make it all work, select a project, check you see a message that includes main.ts.

    📦 Published PR as canary version: 0.0.47--canary.53.792ed16.0
    :sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.47--canary.53.792ed16.0 # or yarn add @chromaui/addon-visual-tests@0.0.47--canary.53.792ed16.0 ```
linear[bot] commented 1 year ago
AP-3562 Send main config location on success/failure

And report it in the UI