Closed ndelangen closed 1 year ago
Allow resetting an accepted test back to "pending". As discussed below, the button does not deal with batching. [Screenshot 2023-09-04 at 14.21.19.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/0eebd433-c94f-4c75-b6c2-0386b477a274/5a776798-c405-466d-9336-a88ddc56bebd)
@ndelangen I've updated this to hide the review button according to @tmeasday's suggestion.
@ghengeveld or @tmeasday did either of you see that I'm blocked here? When I tested this locally, it did not work.
The "How to test" section states where things break. I'd appreciate it either of you could advise or assist.
It did work for me, it just took a while for the UI to update. I created a ticket for that here. Could you try again and see if you get the same effect?
Yes, I see that too, it took about 5 second for me.
What I did:
SnapshotComparison
-component I added an button that is shown when the status isAPPROVED
How to test
I tried this and it did not work! I need help figuring out why!
Open questions:
I suspect that there are scenarios where there's a newer build coming in where "Approve" and "Unapprove" need to be disabled. @tmeasday
📦 Published PR as canary version:
0.0.59--canary.82.de5dbe0.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.59--canary.82.de5dbe0.0 # or yarn add @chromaui/addon-visual-tests@0.0.59--canary.82.de5dbe0.0 ```