search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Show outdated message when new test is available, and disable review button immediately #87

Closed tmeasday closed 1 year ago

tmeasday commented 1 year ago
  1. You can't accept changes when there is a next build
  2. As soon as there's a new snapshot for the current story, we change the header to send you there.

How to QA

  1. Create a build with changes
  2. Browse to the story with changes

  3. Run second build: a. Review button should be disabled as soon as second build reaches the "snapshotting" state b. Header should prompt you to switch stories as soon as the story you are looking at is captured.

    📦 Published PR as canary version: 0.0.66--canary.87.fc95b12.0
    :sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.66--canary.87.fc95b12.0 # or yarn add @chromaui/addon-visual-tests@0.0.66--canary.87.fc95b12.0 ```
linear[bot] commented 1 year ago
AP-3633 Show "Snapshot Outdated" header as soon as we have a new snapshot for the current story

[Snapshot outdated - Visual testing in Storybook (Figma)](https://www.figma.com/file/GFEbCgCVDtbZhngULbw2gP/Visual-testing-in-Storybook?type=design&node-id=2303-374529&mode=design&t=QDk9c7NXhAy2JBqr-0#544903116) **NOTE:** We can detect this state if [`nextBuild.id`](http://nextBuild.id)` !== storyBuild?.id` and the story is captured in the `nextBuild`

tmeasday commented 1 year ago

@MichaelArestad I accidentally merged this but I was still hoping to resolve this final question: https://www.chromatic.com/review?appId=6480e1b0042842f149cfd74c&number=87&type=linked