search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Add a compose `@storybook/components` in our Storybook #88

Closed tmeasday closed 1 year ago

tmeasday commented 1 year ago

@ndelangen this isn't working for me. Any idea why?

image image
📦 Published PR as canary version: 0.0.65--canary.88.12cd3d6.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.65--canary.88.12cd3d6.0 # or yarn add @chromaui/addon-visual-tests@0.0.65--canary.88.12cd3d6.0 ```
ndelangen commented 1 year ago

I'll investigate!

ndelangen commented 1 year ago

Chromatic is returning non-json because storybook isn't requesting the proper URL:

https://next--635781f3500dd2c49e189caf.chromatic.com/?path=/story/blocks-blocks-anchor--default/index.json

Screenshot 2023-09-11 at 11 51 01 Screenshot 2023-09-11 at 11 50 54

AHHH I found it... your URL does contain the query!

ndelangen commented 1 year ago

I'm pushing a fix

tmeasday commented 1 year ago

🤦