chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Keep the "create first build" UI right up until the running build has captured this story #89

Closed tmeasday closed 12 months ago

tmeasday commented 1 year ago

We plan to add a in progress indicator to this: https://linear.app/chromaui/issue/AP-3621#comment-1b9a109b, but in the meantime these stories just make sure the selected builds mirror what we want to happen.

@ghengeveld can you let me know if you want a separate ticket for the "first build" in progress UI linked above, or if you just plan to tackle it as part of what you are doing now.

To test:

  1. Create a new branch
  2. You should see the "create first build" screen
  3. Start the build
  4. The screen should remain there (with button disabled) until there is a captured test for the current story.

    📦 Published PR as canary version: 0.0.74--canary.89.65ca55a.0
    :sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0 # or yarn add @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0 ```
linear[bot] commented 1 year ago
AP-3645 Don't switch to first build until it has completed

As discussed with m we'll keep the "run your first build" with a progress bar until it finishes

ghengeveld commented 1 year ago

@tmeasday Let's make a separate ticket. I don't want to extend the scope of what I'm working on right now.

tmeasday commented 1 year ago

TODO after discussion with @MichaelArestad:

tmeasday commented 1 year ago

Going to need to resolve this with your stuff @ghengeveld so I will hold off merging.