Closed tmeasday closed 12 months ago
As discussed with m we'll keep the "run your first build" with a progress bar until it finishes
@tmeasday Let's make a separate ticket. I don't want to extend the scope of what I'm working on right now.
TODO after discussion with @MichaelArestad:
NextBuildInProgress
story - not expandable, second eyebrow telling you why you can't review (Reviewing is disabled because there's a newer build in progress on main. This can happen when a build runs in CI.
)NextBuildInProgressCapturedStory
story - eyebrow should stay until build is done.Going to need to resolve this with your stuff @ghengeveld so I will hold off merging.
We plan to add a in progress indicator to this: https://linear.app/chromaui/issue/AP-3621#comment-1b9a109b, but in the meantime these stories just make sure the selected builds mirror what we want to happen.
@ghengeveld can you let me know if you want a separate ticket for the "first build" in progress UI linked above, or if you just plan to tackle it as part of what you are doing now.
To test:
The screen should remain there (with button disabled) until there is a captured test for the current story.
📦 Published PR as canary version:
0.0.74--canary.89.65ca55a.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0 # or yarn add @chromaui/addon-visual-tests@0.0.74--canary.89.65ca55a.0 ```