chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Add a UI state for an error on the first build #95

Closed tmeasday closed 11 months ago

tmeasday commented 1 year ago

@MichaelArestad I wasn't sure if there is a component I could use here.

Also I am not sure exactly where this should link to?

📦 Published PR as canary version: 0.0.99--canary.95.19f15a6.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.99--canary.95.19f15a6.0 # or yarn add @chromaui/addon-visual-tests@0.0.99--canary.95.19f15a6.0 ```
linear[bot] commented 1 year ago
AP-3621 Improve first build error handling

I hit a number of issues when creating my first build for test baselines: 1. Since my test repo only has one commit, the build appears to have failed when looking at the CLI output (see screenshot). I should be able to run the addon regardless of how many commits I have. 2. In the UI, the build thinks it's still running. I.e the above error wasn't handled. 3. The UI is stuck waiting for the build to finish with no way to cancel/retry the build, presumably for ever. Some of these issues may exist not in the onboarding build creation scenario as well. [image.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/5927edb8-e328-4a74-a604-e87aed384ce4/e2db80be-87c2-4e62-9f09-44db387d630a)

tmeasday commented 11 months ago

@jonniebigodes any suggestion on the best place the link should go? This is when the Chromatic build errors somewhere, probably most likely the SB build itself. @MichaelArestad suggested https://www.chromatic.com/docs/setup/#troubleshooting

jonniebigodes commented 11 months ago

@tmeasday I'm ok with it for now, as the errors are similar for each case. However, as feedback continues to roll in, I'm more than ok with updating the documentation and setting up a section, possibly named "Debugging Tests", with some additional information and instructions on debugging it. I'm more than glad to update the addon to reflect that change. Sounds good?

tmeasday commented 11 months ago

@weeksling hmm, yes we tweaked the CLI to allow single commit repos from the addon. You could try a repo with no commits at all (not no git setup at all, that will trigger a different issue 😉 ).

It's a while ago now, I think I figured out some main.js that would error for sb build but not for sb dev. Another idea that occurs to me is to just put some junk in your build-storybook script in package.json.

weeksling commented 11 months ago

Got it, thanks! @tmeasday this formatting looks a bit off, but it looks like both the originalError and the formattedError contain the same content. I think we should \ remove the unneeded characters in the error message for the experimental_onTaskError formatter.

Screen Shot 2023-10-04 at 2 53 16 PM