search

chromaui / addon-visual-tests

Visual Tests addon for Storybook
MIT License
33 stars 2 forks source link

Onboarding: Show auth screen when projectId is detected #99

Closed ndelangen closed 11 months ago

ndelangen commented 1 year ago

What I did:

When the user opens the storybook with the projectId already setup, they don't need to opt-in to the addon anymore, thus the welcome screen should be skipped.

Unfortunately the isSetup flag I added is only detected later on, so I had to add a little useEffect to set the state correctly as the flag flips after the first render.

📦 Published PR as canary version: 0.0.87--canary.99.f31a776.0
:sparkles: Test out this PR locally via: ```bash npm install @chromaui/addon-visual-tests@0.0.87--canary.99.f31a776.0 # or yarn add @chromaui/addon-visual-tests@0.0.87--canary.99.f31a776.0 ```
linear[bot] commented 1 year ago
AP-3552 Ensure onboarding for second user in project works

[image.png](https://uploads.linear.app/cfa7d1b1-ff77-4dbe-ae92-8cf23f92a7a9/43aa0b78-700e-4d19-92ab-6d148fdb337d/e0117234-0e3a-4406-ac09-193225f2d113) It's weird to me to see this when Visual Tests is already set up and active. Should we be showing this to folks after someone has already set it up? I would expect to see the login screen. What do you think?