search

chromaui / chromatic-cli

Chromatic CLI: `npx chromatic`
https://www.chromatic.com/docs/cli
MIT License
285 stars 71 forks source link

Clean package.json before compiling into source #1003

Closed ghengeveld closed 3 months ago

ghengeveld commented 3 months ago

The contents of package.json is compiled into the GitHub Action source code, so we need to clean that up as well.

📦 Published PR as canary version: 11.5.4--canary.1003.9398324441.0
:sparkles: Test out this PR locally via: ```bash npm install chromatic@11.5.4--canary.1003.9398324441.0 # or yarn add chromatic@11.5.4--canary.1003.9398324441.0 ```
ethriel3695 commented 3 months ago

@ghengeveld I tested this on my vite-project in Chromatic with the Canary. I used pnpm and node 22 and the GitHub Action workflow passed. https://github.com/chromaui/vite-project/actions/runs/9390707539/job/25861177410

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 7728406954f7da75c519d95c3a620aa477b270da[^1] :white_check_mark: ∅ (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (7728406954f7da75c519d95c3a620aa477b270da) | Report Missing | Report Missing | Report Missing | | | Head commit (053500f1c9d3087e803e45e6c7dec4aa462e181c) | 8457 | 6676 | 78.94% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#1003) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

ghengeveld commented 3 months ago

:rocket: PR was released in v11.5.3 :rocket: