chromaui / chromatic-cli

Chromatic CLI: `npx chromatic`
https://www.chromatic.com/docs/cli
MIT License
289 stars 70 forks source link

Don't upload files from `.chromatic` directory #1028

Closed jmhobbs closed 1 month ago

jmhobbs commented 2 months ago

This is largely caused by using pre-built storybooks with the -d / --storybook-build-dir flag. Filtering out this directory will prevent accidental upload of reserved files like trace metadata or processing sentinels.

📦 Published PR as canary version: 11.9.0--canary.1028.10799660620.0
:sparkles: Test out this PR locally via: ```bash npm install chromatic@11.9.0--canary.1028.10799660620.0 # or yarn add chromatic@11.9.0--canary.1028.10799660620.0 ```
codacy-production[bot] commented 2 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 5f0500fe5e0656c6eadf44b4af8a8a678abb15ea[^1] :white_check_mark: 100.00% (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (5f0500fe5e0656c6eadf44b4af8a8a678abb15ea) | Report Missing | Report Missing | Report Missing | | | Head commit (69e24e0344ffa43c4ace72a75c75353194018905) | 8478 | 6698 | 79.00% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#1028) | 5 | 5 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

ghengeveld commented 1 month ago

This is good. I was worried we wouldn't be uploading any metadata files anymore, but that's actually handled in a separate file (uploadMetadataFiles.ts).

ghengeveld commented 1 month ago

:rocket: PR was released in v11.8.0 :rocket: