chromaui / chromatic-cli

Chromatic CLI: `npx chromatic`
https://www.chromatic.com/docs/cli
MIT License
285 stars 71 forks source link

Use double quotes around command arguments #985

Closed tevanoff closed 4 months ago

tevanoff commented 4 months ago

When passing file paths to the git ls-files command to search for package manifest files, the paths are currently wrapped in single quotes.

This seems to be problematic on windows:

const results = await execGitCommand(`git ls-files --full-name -z 'C:/my/project/package.json'`);
console.log('execGitCommand results:', results);
...
execGitCommand results:
Done in 0.58s.

Switching to double quotes does the trick:

const results = await execGitCommand(`git ls-files --full-name -z "C:/my/project/package.json"`);
console.log('execGitCommand results:', results);
...
execGitCommand results: package.json
Done in 0.64s.
📦 Published PR as canary version: 11.3.6--canary.985.9099248277.0
:sparkles: Test out this PR locally via: ```bash npm install chromatic@11.3.6--canary.985.9099248277.0 # or yarn add chromatic@11.3.6--canary.985.9099248277.0 ```
codacy-production[bot] commented 4 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d4b3fe20aadb180c8af62de25d8a6f13e00de929[^1] :white_check_mark: 100.00% (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (d4b3fe20aadb180c8af62de25d8a6f13e00de929) | Report Missing | Report Missing | Report Missing | | | Head commit (e7be52ea874404a0ce32c1c06d1aa79657ad677a) | 8467 | 6669 | 78.76% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#985) | 1 | 1 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

ghengeveld commented 4 months ago

:rocket: PR was released in v11.3.5 :rocket: