chromaui / chromatic-cli

Chromatic CLI: `npx chromatic`
https://www.chromatic.com/docs/cli
MIT License
285 stars 71 forks source link

Pass `CI=1` environment variable to Storybook build command to disable prompts #991

Closed ghengeveld closed 3 months ago

ghengeveld commented 3 months ago

This should prevent the Storybook build script from prompting (e.g. to send a crash report), which would cause the CLI to hang.

As an added bonus, preferLocal might help ensure we use a locally installed package over a global one.

📦 Published PR as canary version: 11.4.1--canary.991.9225753804.0
:sparkles: Test out this PR locally via: ```bash npm install chromatic@11.4.1--canary.991.9225753804.0 # or yarn add chromatic@11.4.1--canary.991.9225753804.0 ```
linear[bot] commented 3 months ago

AP-4602 CLI hangs if Storybook build fails and prompts you for crash reports

codacy-production[bot] commented 3 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark: 100.00% (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (24e744cfb40a738d4a5e476a3e81f5bd78995581) | 8471 | 6675 | 78.80% | | | Head commit (a1375ffc0540c58c1bd7dc54b7ddbcda5692f05a) | 8472 (+1) | 6676 (+1) | 78.80% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#991) | 2 | 2 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more