search

chromaui / chromatic-cli

Chromatic CLI: `npx chromatic`
https://www.chromatic.com/docs/cli
MIT License
289 stars 70 forks source link

Only replace *local* builds with uncommitted changes #994

Closed ghengeveld closed 5 months ago

ghengeveld commented 5 months ago

Rather than always replacing any baseline builds with uncommitted changes, only apply this behavior to local builds. This restores the original behavior from before v11.4.0 (#988) for non-local builds.

Depends on https://github.com/chromaui/chromatic/pull/8665

Note that this does not require a CLI version bump in the VTA because by definition this update will only affect non-local (i.e. non-VTA) builds.

📦 Published PR as canary version: 11.5.2--canary.994.9355913361.0
:sparkles: Test out this PR locally via: ```bash npm install chromatic@11.5.2--canary.994.9355913361.0 # or yarn add chromatic@11.5.2--canary.994.9355913361.0 ```
linear[bot] commented 5 months ago

AP-4668 Customers hit error: `Build had uncommitted changes`

codacy-production[bot] commented 5 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c5e07cfdbfebcf104f64bc421260a5c25965f2ab[^1] :white_check_mark: 100.00% (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (c5e07cfdbfebcf104f64bc421260a5c25965f2ab) | Report Missing | Report Missing | Report Missing | | | Head commit (e53dc2d4c97e2f38a01ff50067aeb26836d450c0) | 8458 | 6675 | 78.92% | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#994) | 9 | 9 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more [^1]: Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

ghengeveld commented 5 months ago

:rocket: PR was released in v11.5.1 :rocket: