search

chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
21 stars 4 forks source link

Manual snapshots don't work when disableAutoSnapshot=true #131

Closed zernie closed 4 months ago

zernie commented 4 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. set disableAutoSnapshot: true
  2. call cy.takeSnapshot()

Expected behavior

A manual snapshot is saved to cypress/downloads

Actual behavior

Manual snapshot is not saved

Screenshots If applicable, add screenshots to help explain your problem.

Additional context

The issue is in @chromatic-com/cypress/support afterEach callbacks

skitterm commented 4 months ago

@zernie thanks for reporting, we just shipped a fix for this (you'll need to upgrade @chromatic-com/cypress to version 0.6.9 or later). Kudos to @jackleslie for the fix!