chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
21 stars 4 forks source link

Change save function to something less likely to be overridden #132

Closed andrewortwein closed 4 months ago

andrewortwein commented 4 months ago

Issue: #AP-4584

What Changed

I changed the Playwright test fixture save function to chromaticSave, something more specific that should have a much less chance of being overridden by a customer who is using their own extended fixture.

How to test

Run the tests.

linear[bot] commented 4 months ago

AP-4584 E2E - The builds don't generate the test-archives in test-results anymore

codacy-production[bot] commented 4 months ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark: (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (4ca81355a25f52b75449f232f7be84a18772d111) | 218 | 208 | 95.41% | | | Head commit (b2ef21f5a1a5fadfc59419f8633583ba0d2705bd) | 218 (+0) | 208 (+0) | 95.41% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#132) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

andrewortwein commented 4 months ago

@andrewortwein In order to cut a release with this change, you'll need to add a changeset. Lmk if anything in the instructions is not clear!

Thanks, Todd. The process seemed pretty intuitive to me, but please let me know if we should change anything about it.