search

chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
21 stars 4 forks source link

fix: `disableAutoSnapshot` not working as expected #134

Closed jackleslie closed 4 months ago

jackleslie commented 4 months ago

Issue: https://github.com/chromaui/chromatic-e2e/issues/131

What Changed

From documentation:

When true, will disable the snapshot that happens automatically at the end of a test when using the Chromatic test fixture.

I believe currently when disableAutoSnapshot is set to true we are not proceeding to the prepareArchives task, so rather than disabling the automatic snapshot we are disabling all snapshots

How to test

  1. set disableAutoSnapshot: true globally
  2. call cy.takeSnapshot()
jackleslie commented 4 months ago

Hi there @tevanoff @skitterm, just wanted to bump this hope that's okay 🙏

skitterm commented 4 months ago

@jackleslie thanks for identifying the issue and making the fix! We'll take a look at this.

jackleslie commented 4 months ago

@skitterm thanks for taking a look! I see that some checks are still failing, is there anything I need to do?

skitterm commented 4 months ago

@skitterm thanks for taking a look! I see that some checks are still failing, is there anything I need to do?

@jackleslie you're good! I'll take it from here. Some checks require the PR to be from a non-fork branch to pass. I'll change this base branch to my (non-fork) branch, and after merging I'll make another PR from my branch to main. Planning on having this deployed by the end of today (US pacific time).