chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
13 stars 3 forks source link

Remove the runtime~main file to render Storybook correctly #146

Closed ethriel3695 closed 1 month ago

ethriel3695 commented 1 month ago

Issue: #

What Changed

We have one additional file that needs to be excluded for E2E target storybooks to render correctly.

How to test

codacy-production[bot] commented 1 month ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.00% (target: -1.00%) :white_check_mark: (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (ed7a2a636bc662739e3c1ca8e1f0181af5fbf9e2) | 225 | 215 | 95.56% | | | Head commit (c1b9527d0086cf0e130652da64c4ee65418451f6) | 225 (+0) | 215 (+0) | 95.56% (**+0.00%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#146) | 0 | 0 | **∅ (not applicable)** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

skitterm commented 1 month ago

@ethriel3695 I've accepted the one flaky UI Test, this looks good to merge from my end! Can you QA it on production after you merge it?

ethriel3695 commented 1 month ago

@ethriel3695 I've accepted the one flaky UI Test, this looks good to merge from my end! Can you QA it on production after you merge it?

Of course! I'll test and merge in the morning though as I won't be around to monitor it right now.

thafryer commented 1 month ago

@ethriel3695 Is there a ticket related to this?

ethriel3695 commented 1 month ago

@ethriel3695 Is there a ticket related to this?

@thafryer not yet.

Also, I have a question. I'm running the canary locally and the two new files I added to the list are not getting hashed. Do you know why? Is it possible it's the .js extension?

Ah, the files are not part of the bundled code in node_modules

I added tests to verify the hashing works.