Avoid EISDIR errors by always adding a file extension to archived files

[tevanoff]

Issue: #

What Changed

Ensures there's always a file extension even when there's no file extension found for a given content type to avoid EISDIR errors on file/directory collisions.

How to test

• Pull this down, revert the fix in archive-file.ts, run yarn build && yarn test:playwright, see EISDIR errors
• Put the fix back in place, rebuild and rerun playwright tests, see all is 💯

[codacy-production[bot]]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: -0.02% (target: -1.00%)	:white_check_mark: 100.00% (target: 80.00%)

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (1d8b6dff2afcd3c0f11ed8f0dd45fbdbf7e69772) | 225 | 215 | 95.56% | | | Head commit (93157ec1c2fcea89cc75146e2bff26ffb9666517) | 224 (-1) | 214 (-1) | 95.54% (**-0.02%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#147) | 3 | 3 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

_{Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more}

[ghengeveld]

What happens to these .tmp files? Are they eventually used in any way? I wonder if it makes more sense to just drop them?

[tevanoff]

What happens to these .tmp files? Are they eventually used in any way? I wonder if it makes more sense to just drop them?

@ghengeveld They can be used if they are referenced in the DOM, yeah. We don't really keep track of that yet. I used .tmp as the default because it felt like the most generic, but lmk if you have a better suggestion for that.