search

chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
21 stars 4 forks source link

Add delaySnapshot env config #161

Open tsirlucas opened 4 months ago

tsirlucas commented 4 months ago

Is your feature request related to a problem? Please describe. I have similar problem you propose to solve using delay env config. But instead of waiting for an animation in the generated storybook, i want to wait a few ms before taking the snapshots. More specifically before cy.document() call.

Describe the solution you'd like Basically following check before cy.document() call would do:

if (Cypress.env("delaySnapshot") { cy.wait(Cypress.env("delaySnapshot")) }

Describe alternatives you've considered Currently I've patched the package and added it myself. I can open the PR if you guys want.

Additional context N/A

tevanoff commented 4 months ago

@tsirlucas thanks for the suggestion! If possible, we'd like to leverage the testing framework to help with this. Could this be accomplished by using cy.wait or another Cypress method to wait for an element in the relevant tests?

tsirlucas commented 4 months ago

yes its possible. in fact, its what i've done basically. it would be easier to have it as a config but im good with my workaround