chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
13 stars 3 forks source link

Use configured `downloadsFolder` for Cypress #164

Open tevanoff opened 1 week ago

tevanoff commented 1 week ago

Issue: #

What Changed

The Cypress integration was hardcoded to use Cypress's default value for downloadsFolder, cypress/downloads. Changes to that in the Cypress config would not be respected, and archive files would always be written to the default.

This fixes that by reading the correct value from the Cypress config object.

How to test

codacy-production[bot] commented 1 week ago

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
:white_check_mark: +0.02% (target: -1.00%) :white_check_mark: 100.00% (target: 80.00%)
Coverage variation details | | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (753f16790758d4771c34502acacd0f420cbd44a6) | 259 | 245 | 94.59% | | | Head commit (a4cd9c49ab30c0253bf654a3956c92b29b4c294e) | 260 (+1) | 246 (+1) | 94.62% (**+0.02%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `
Diff coverage details | | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#164) | 2 | 2 | **100.00%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences


:rocket: Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

andrewortwein commented 1 week ago

@skitterm, Todd brought up that we don't currently have any unit tests that verify things are written to a configured outputDir. But we also don't have any tests covering the default case, so this could be a bit of a rabbit hole. Do you have any opinion on whether it's worth prolonging this fix to implement tests in this area?

skitterm commented 1 week ago

Do you have any opinion on whether it's worth prolonging this fix to implement tests in this area?

@andrewortwein @tevanoff my gut says that it's not worth the time to add the tests, where we didn't see an easy way of putting them in.