Open tevanoff opened 1 week ago
Coverage variation | Diff coverage |
---|---|
:white_check_mark: +0.02% (target: -1.00%) | :white_check_mark: 100.00% (target: 80.00%) |
:rocket: Don’t miss a bit, follow what’s new on Codacy.
Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more
@skitterm, Todd brought up that we don't currently have any unit tests that verify things are written to a configured outputDir
. But we also don't have any tests covering the default case, so this could be a bit of a rabbit hole. Do you have any opinion on whether it's worth prolonging this fix to implement tests in this area?
Do you have any opinion on whether it's worth prolonging this fix to implement tests in this area?
@andrewortwein @tevanoff my gut says that it's not worth the time to add the tests, where we didn't see an easy way of putting them in.
Issue: #
What Changed
The Cypress integration was hardcoded to use Cypress's default value for
downloadsFolder
,cypress/downloads
. Changes to that in the Cypress config would not be respected, and archive files would always be written to the default.This fixes that by reading the correct value from the Cypress config object.
How to test
downloadsFolder
to a non-default value incypress.config.ts
cypress/downloads