chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
21 stars 4 forks source link

Fix shared package dependencies #65

Closed tevanoff closed 8 months ago

tevanoff commented 8 months ago

Issue: #

What Changed

Regular dependencies of the shared package will be bundled up into the external pw/cy package's code when they are built, unless they are also dependencies of those packages.

This moves most of shared's dependencies to devDependencies so they are bundled up with its code rather than the pw/cy code. Either works, but this feels a bit cleaner.

The couple of packages that haven't been moved are also dependencies of the external pw/cy packages, so they won't get bundled up in those packages. The @segment/analytics-node package does not need to be a dependency of those, but it causes compilation warnings when it is bundled so the move is to avoid that.