Differentiates between Cypress' "run mode" (used for CI) and "interactive mode" (used for interactively clicking through tests and seeing the DOM), via config.isTextTerminal. This is so we don't need users to prepend their cypress open command with the ELECTRON_EXTRA_LAUNCH_ARGS env variable, and also makes it so we won't archive in interactive mode.
Previously I had tried doing this through config.isInteractive in #72, but due to a Cypress bug that value wasn't getting the correct values in all cases.
Note that config.isTextTerminal is undocumented. However, it's the way users in the bug ticket recommended to do, and more importantly, it's how Cypress appears to be telling things whether to be in "run mode" or "interactive mode" in their tests, so we should be pretty safe.
API Change
This requires Cypress users to now pass config to installPlugin, as follows:
Issue: #AP-4060
What Changed
Differentiates between Cypress' "run mode" (used for CI) and "interactive mode" (used for interactively clicking through tests and seeing the DOM), via
config.isTextTerminal
. This is so we don't need users to prepend theircypress open
command with theELECTRON_EXTRA_LAUNCH_ARGS
env variable, and also makes it so we won't archive in interactive mode.Previously I had tried doing this through
config.isInteractive
in #72, but due to a Cypress bug that value wasn't getting the correct values in all cases.Note that
config.isTextTerminal
is undocumented. However, it's the way users in the bug ticket recommended to do, and more importantly, it's how Cypress appears to be telling things whether to be in "run mode" or "interactive mode" in their tests, so we should be pretty safe.API Change
This requires Cypress users to now pass
config
toinstallPlugin
, as follows:How to test
Cypress run command:
yarn test:cypress
is runChromatic build:
UI Tests: Cypress
Chromatic buildCypress, interactive mode:
Locally, check out this branch and run
yarn
Locally, blow away contents of
packages/cypress/tests/downloads
folder (to ensure no hold-over archives are there)Locally, run
yarn test:server
Locally, run
yarn cypress open --project packages/cypress/tests
Click through all the tests (for Electron and Chrome)
Verify that the server console doesn't print any errors (CDP or otherwise)
Verify that all the tests pass
Verify that even the manual-snapshotted tests run
Verify that the
packages/cypress/tests/downloads
folder is still empty[x] Author QA