search

chromaui / chromatic-e2e

Archive end-to-end tests to be replayed in Storybook and Chromatic
MIT License
13 stars 3 forks source link

Move storybook to direct dependency #86

Closed tmeasday closed 5 months ago

tmeasday commented 5 months ago

Telescoping on https://github.com/chromaui/test-archiver/pull/84

What Changed

Made SB a direct dependency rather than peer.

How to test

Try installing the package into:

  1. Project w/o SB
  2. Project w/ SB installed in same dir
  3. Project w/ SB installed elsewhere in a monorepo
tmeasday commented 5 months ago

OK, I tried the above 3 setups with yarn pnp, yarn 4, pnpm and npm, and it seemed to work. I think there are a lot of ways things could get more complex, but so far it looks good. I think good enough to go on with.

tmeasday commented 5 months ago

@tevanoff I tested the canary with SB7 projects across yarn/pnpm and npm both in monorepo and single project situations and it worked well! I say we merge it?