search

chromaui / learnstorybook.com

Static site and content for Storybook tutorials
https://storybook.js.org/tutorials/
MIT License
2.4k stars 436 forks source link

Created the get-started.md file in portuguese for React Native #679

Closed pablolucas890 closed 1 year ago

pablolucas890 commented 1 year ago

Hello, My name is Pablo and I'm starting to contribute with Open Source. From my first contuibuition for React Native, i'll be translate the storybook for portuguese. Firstly I start with get-started.md, but I want to help more.

jonniebigodes commented 1 year ago

@pablolucas890, sorry for the delayed response, but it's been a couple of hectic weeks with the upcoming release of Storybook beta 7.0, and I had to devote my attention to other documentation-related items. With that being said, thank you so much for taking the time and effort to put together this pr to add a translation for the React Native version tutorial. We appreciate it 🙏 .

I was wondering if you're willing to add the remaining sections so that we can have a full tutorial which can be released as a whole. I saw that @Wanderson77 has already shown interest as well. So, with that in mind, probably, both of you can collaborate on it, and if @Wanderson77 is willing, he can help proofread it. Does that work for both of you? Also, I would like to take the opportunity to let you both know that the React Native version of Storybook is currently in beta with some cool additions to add the same experience as a normal Storybook instance (e.g., Angular, React, Svelte) provides, if you're both interested in helping the maintainer and us, check out the repository and let us know.

Hope both of you have a great weekend.

Looking forward to hearing from you and seeing this translation released.

Stay safe

pablolucas890 commented 1 year ago

Hii @jonniebigodes, yeah I and @Wanderson77 want to contribute with this repo, for moment we go traduce the react native to portuguese and in the future we want contribute more with storybook, you can help us with it?

Wanderson77 commented 1 year ago

https://storybook.js.org/tutorials/intro-to-storybook/react-native/en/get-started/ @jonniebigodes The PR has not yet been approved for what reason?

jonniebigodes commented 1 year ago

@Wanderson77, to answer your question, as you may or may not have seen, Storybook entered beta recently, and it required some documentation changes, and that's been my focus over the past months. Also, as you're aware, the year is almost over, and some folks at Storybook, including myself, took some time off to enjoy the holidays with our families. Next week I'll take a proper look at it, and if nothing stands out, I'll be more than glad to merge this so that you and @pablolucas890 continue to work on the translation. Sounds good?

Hope you have a great day.

Stay safe

jonniebigodes commented 1 year ago

@pablolucas890 just a friendly reminder to see if you're still able to work on this, as the React Native version was recently updated to factor in the required changes for Storybook 7.0. Let me know, and we'll go from there.

For the time being I'm converting this into a draft pull request so that we can get a clear sense on the path moving forward.

Hope you have a great week.

Stay safe

pablolucas890 commented 1 year ago

Hi @jonniebigodes How are u doing? I'm sorry for don't pay atemption for this PR, in last days I had a little bit work on my job...

The documentation have updates on get started for Storybook 7.0?

If yes, let me update the translate and ask for some friend review and maybe aprove...

What do u think?

jonniebigodes commented 1 year ago

Hey @pablolucas890 , sorry for not responding sooner, but I got sidetracked with other documentation issues that required my attention. Technically the React Native version is still not on 7.0, it's still running on 6.5, but it already has some of the 7.0 features added in, thanks to the lead maintainer, which you can see on the English version. If you're still interested in working on it, let me know, and I'll remove the draft status. @Wanderson77 if you're able, can you combine your efforts with @pablolucas890 so that we're able to release it soonish?

Looking forward to hearing from you both.

Have a fantastic weekend.

Stay safe

Wanderson77 commented 1 year ago

@jonniebigodes You can remove the draft status and we will translate this documentation. thank you and wait.

jonniebigodes commented 1 year ago

@Wanderson77 thanks for following up with me on this. All done, I've updated it. Looking forward to getting this one in.

pablolucas890 commented 1 year ago

@jonniebigodes Can I close this PR? the @Wanderson77 opened another with more translates =)

jonniebigodes commented 1 year ago

@pablolucas890 I saw the notification, but I hadn't had the time to review it and follow up with you on this one. I'm good with closing this and continuing the translation effort in the other one. Sounds good?

Have a fantastic day.

Stay safe