search

chromaui / learnstorybook.com

Static site and content for Storybook tutorials
https://storybook.js.org/tutorials/
MIT License
2.4k stars 436 forks source link

Update french intro-to-storybook for React #695

Closed xaviermarchal closed 1 year ago

xaviermarchal commented 1 year ago

…version #3

xaviermarchal commented 1 year ago

Hello @jonniebigodes, i updated 10 french files located in the intro-to-storybook for React.

How code review is done for translations?

xaviermarchal commented 1 year ago

Hello @jonniebigodes up on this topic?

jonniebigodes commented 1 year ago

@xaviermarchal a friendly reminder to see if you're still planning on updating the tutorial. Also, so that you're aware, the English version is already updated to Storybook 7.0, so you might want to consider factoring in the changes.

Looking forward to hearing from you.

Have a great week.

Stay safe

xaviermarchal commented 1 year ago

@xaviermarchal a friendly reminder to see if you're still planning on updating the tutorial. Also, so that you're aware, the English version is already updated to Storybook 7.0, so you might want to consider factoring in the changes.

Looking forward to hearing from you.

Have a great week.

Stay safe

Hello @jonniebigodes , good catch, i have not been on the repo for couple of weeks !

I feel like, to be able to merge as soon as possible, it could be interesting to merge the PR, and doing the changes for Sotrybook 7 in another PR, what do you think?

I did the changes noted in the code review. I see there may be conflicts. Do you need my help? Is it okay to merge?

I do not know if i miss something, but when i fetch origin and rebase to master, i do not see any changes, so i feel like i'm up to date, and don't understand the conflicts i could have.

jonniebigodes commented 1 year ago

@xaviermarchal, no worries about it, and that does indeed sound like a plan. I can take care of the merge conflicts tomorrow morning my time and get this merged once you've addressed the last item of feedback that I've mentioned. Then we can go from there and follow up with a pull request with the 7.0 changes.

Looking forward to hearing from you.

Hope you have a fantastic rest of the weekend.

xaviermarchal commented 1 year ago

@xaviermarchal, no worries about it, and that does indeed sound like a plan. I can take care of the merge conflicts tomorrow morning my time and get this merged once you've addressed the last item of feedback that I've mentioned. Then we can go from there and follow up with a pull request with the 7.0 changes.

Looking forward to hearing from you.

Hope you have a fantastic rest of the weekend.

@jonniebigodes Normally i pushed all your feedbacks, is there one i forgot?

Regards !

jonniebigodes commented 1 year ago

@xaviermarchal, the only item left was this one which wasn't solved when I wrote the response, but it seems that now it is. I've already addressed the merge conflicts and going to merge this as is.

Looking forward to seeing the 7.0 updates soon.

Hope you have a great week.

Stay safe