chromaui / learnstorybook.com

Static site and content for Storybook tutorials
https://storybook.js.org/tutorials/
MIT License
2.4k stars 436 forks source link

Diff not showing correctly in the snippets #720

Open jonniebigodes opened 1 year ago

jonniebigodes commented 1 year ago

When a user browses the tutorials, he's faced with an issue where the snippets defined as a diff (e.g., Simple Component section) mentioning the required changes are not showing up correctly. For example:

diff-not-showing-prod

However, this situation doesn't happen when running a development build of the tutorials website. For example:

diff-working-dev-mode

What needs to happen:

Thanks for the reminder @valentinpalkovic and @cdedreuille; if you have any ideas for design, would love to pair on them with you and address this issue.

cdedreuille commented 1 year ago

@jonniebigodes I would be happy to help with this one. We need to see what the highlighter could do.

Let's pair whenever you want.

jonniebigodes commented 1 year ago

To try and figure out the issue, I did some preliminary testing, and something may be happening on the deployment front.

diff-loading-local-prod-build

fpigeonjr commented 11 months ago

same issue on Safari 😞

image