search

chromaui / learnstorybook.com

Static site and content for Storybook tutorials
https://storybook.js.org/tutorials/
MIT License
2.4k stars 436 forks source link

Translation React Intro to Storybook to italian #734

Closed ludovicobesana closed 9 months ago

ludovicobesana commented 10 months ago

Translating the React Intro to Storybook into Italian! 🎉

"/intro-to-storybook/react/it/get-started/"

giowhatever commented 10 months ago

Hi I saw the message on discord about the translation in Italian and I wanna help if possible. For me it's the first time contributing on an open-source project on github. Do I need to check all the commits and give my feedback with the "review changes" functionality?

Archetipo95 commented 10 months ago

Hi @jonniebigodes I proofread everything and I left some comments. Good job to @ludovicobesana for the translations! I think that 90% of his work could be used for the Vue.js tutorial too, if I find the time I could help with that.

NB @jonniebigodes I just read the translations, you should check the code and all the links.

Archetipo95 commented 10 months ago

Hi I saw the message on discord about the translation in Italian and I wanna help if possible. For me it's the first time contributing on an open-source project on github. Do I need to check all the commits and give my feedback with the "review changes" functionality?

Hi 🙂 you could also just leave comments on every line of code that you have something to say.

jonniebigodes commented 10 months ago

@Archetipo95 and @giowhatever appreciate the follow-up on this 🙏 ! Leave any comments you have in this pull request so that @ludovicobesana is aware, and we'll take it from there. And to your comment, yes, the tutorial was created to be as framework-agnostic as possible. If you find the time, please submit a pull request, and we'll get it proofread if both @ludovicobesana or @giowhatever are willing to do it as with this one.

ludovicobesana commented 10 months ago

@giowhatever Thank you for the precious feedbacks 🙏🏻 I should have fixed all with this commit: ac7427b

cc. @jonniebigodes

jonniebigodes commented 9 months ago

@ludovicobesana on my end, this looks amazing. Thanks for taking care of the feedback so soon. I'm going to merge it and get it published. @giowhatever, a big thank you to you as well for taking the time to proofread it and follow up with @ludovicobesana. Appreciate it 🙏

One small thing to take care of, @ludovicobesana and @giowhatever, can both of you message me directly (same username) on our Discord Server so that I can follow up with you both?

Looking forward to hearing from you.

Hope both of you have a fantastic day.

Stay safe