search

chromaui / learnstorybook.com

Static site and content for Storybook tutorials
https://storybook.js.org/tutorials/
MIT License
2.4k stars 436 forks source link

Updated Japanese translation for Angular version of introduction to Storybook #746

Open nagashimam opened 8 months ago

nagashimam commented 8 months ago

This PR updates Japanese translation for Angular version of introduction to Storybook

Angular版introduction to Storybookの日本語訳更新です。

jonniebigodes commented 8 months ago

@nagashimam, thank you so much for putting together this pull request and helping us update the translation to the latest version of Storybook. We appreciate it 🙏 ! I'll take a closer look on my end in the coming days, but in the meantime, I was wondering if @chameleonhead would be interested in taking a pass and proofreading it. If you don't, it's more than okay, and we'll work something out.

Hope you have a fantastic day.

Stay safe.

jonniebigodes commented 7 months ago

@nagashimam, one thing for you as you already have this pull request up. I've just pushed #748 with some changes to the tutorials, including the Intro to Storybook to the latest stable version of Storybook (i.e., 7.6). Can you adjust your pull request and factor these changes if you're ok with it? It's just a minor update to the Screen section of the tutorial, nothing significant.

Looking forward to hearing from you.

Have a fantastic weekend.

Stay safe

nagashimam commented 7 months ago

@jonniebigodes Sorry for being late. I updated links and their texts, and reflected updates from 7.5 to 7.6. Could you take a look at the branch again?

jonniebigodes commented 7 months ago

@nagashimam, please, no need to be sorry. I can understand if you're busy with family, work, or any other engagement that requires your attention. I really appreciate it you taking the time to get the updates in so promptly 🙇 . On my end is all good. All I wanted was for @chameleonhead to proofread it. @chameleonhead, if you don't have the time, it's all good for the same reasons as @nagashimam. We can reach out to the community and see if anyone is willing to help us proofread it and get it published.

Looking forward to hearing from you.

chameleonhead commented 7 months ago

@jonniebigodes @nagashimam Sorry for my late reply. I will start proofreading shortly. Thank you.

jonniebigodes commented 7 months ago

@chameleonhead, thanks for following up with me on this. There is no need to be sorry whatsoever. I completely understand it; we're all busy here 🙂

shoegaze commented 6 months ago

@jonniebigodes @nagashimam

Hi, I would love to proofread the PR if @chameleonhead is busy!

chameleonhead commented 6 months ago

@shoegaze Thank you for your proposal. I would appreciate it if you could do proofreading.

I have done following chapters.

I would like you to proofread from deploy.md to the end. (Of course you can do all.)

If it is ok, then I will send incomplete review. Thank you.

jonniebigodes commented 6 months ago

@shoegaze, that's great to hear. I appreciate you taking the time to help @chameleonhead by proofreading the translation 🙏 ! Once it's done, let me know so that @nagashimam can address the feedback and merge the pull request, making it available to our readers.

Have a fantastic day.

Stay safe

nagashimam commented 6 months ago

@chameleonhead (@shoegaze @jonniebigodes) Thank you for your time and effort. I'm moving to a new town next week, so I can't make time for this. I'll get back to you guys by the mid of March🙇‍♂️

jonniebigodes commented 5 months ago

@nagashimam, thanks for following up with me on this. And all is good, no rush. Depending on your time frame, we can tackle these changes and update it for Storybook 8. Good luck with your move to the new town.

chameleonhead commented 1 month ago

@nagashimam I am going to re-start proofreading. Sorry for waiting so mutch. I will notice you when I finish. Thank you.