chromaui / learnstorybook.com

Static site and content for Storybook tutorials
https://storybook.js.org/tutorials/
MIT License
2.4k stars 436 forks source link

Italian translations for vue of intro-to-storybook #756

Closed Archetipo95 closed 3 months ago

Archetipo95 commented 4 months ago

Huge thanks to @ludovicobesana for the React translations which I took for this Vue translation

Archetipo95 commented 4 months ago

@jonniebigodes I fixed the issues that you mentioned in the comments. If you have something else feel free to give me a feedback!

jonniebigodes commented 4 months ago

@Archetipo95 appreciate you addressing the feedback so promptly 🙏 ! From my end, all is good. I'll message @ludovicobesana tomorrow morning my time and see if he has time to take a look into this, so that we're able to get the feedback addressed as soon as possible and publish the translation.

If he's unable to review it in a reasonable timeframe. I'll go ahead and merge this, and we can make some adjustments in a follow-up pull request.

Sounds reasonable to you?

Have a fantastic day.

Stay safe

Archetipo95 commented 4 months ago

Absolutely, it sounds awesome! Addressing feedback promptly is crucial for maintaining momentum 🚀

Wishing you a fantastic day as well!

ludovicobesana commented 4 months ago

@jonniebigodes I'll do the review by Sunday 7th. Thanks again for your contribution @Archetipo95 🙏🏻

jonniebigodes commented 4 months ago

Appreciate it @ludovicobesana 🙏

ludovicobesana commented 4 months ago

@Archetipo95 I'm looking it right now in code from here: https://github.com/Archetipo95/learnstorybook.com/tree/master

ludovicobesana commented 4 months ago

@Archetipo95 I've done a quick review, could you please check the feedbacks that I've added? Thank you! 🙏🏻

Now I need to go but tomorrow I'll check if I found other things that can be improved.

cc. @jonniebigodes

Archetipo95 commented 4 months ago

@jonniebigodes I resolved all the suggestions that @ludovicobesana raised. If you want to close it feel free :D

ludovicobesana commented 4 months ago

@jonniebigodes I resolved all the suggestions that @ludovicobesana raised. If you want to close it feel free :D

Hi @Archetipo95, I see only one commit with one fix: https://github.com/chromaui/learnstorybook.com/pull/756/commits/e6711b4ad3f5a71f95b1571adde2eb9398757a11

Can you please look a the other feedbacks that I've added for you? Thank you! 🙏🏻

Archetipo95 commented 4 months ago

Hi :D @ludovicobesana I did both fixes in one commit Am I missing something?

Screenshot 2024-04-15 at 22 05 10
ludovicobesana commented 4 months ago

Hi :D @ludovicobesana I did both fixes in one commit Am I missing something? Screenshot 2024-04-15 at 22 05 10

@Archetipo95 I've re-added this points and also if you can check also the other new parts of translations that could be great!

Archetipo95 commented 4 months ago

Done! Sorry I messed something and I was not seeing your suggestions :D thanks for tagging me @ludovicobesana Now everything should be resolved, I accepted all of your suggestions, thanks for taking time to check this PR

ludovicobesana commented 4 months ago

Done! Sorry I messed something and I was not seeing your suggestions :D thanks for tagging me @ludovicobesana Now everything should be resolved, I accepted all of your suggestions, thanks for taking time to check this PR

Cool thank you, did you check the other documentation files too? Just to have a double check.

jonniebigodes commented 3 months ago

@Archetipo95 and @ludovicobesana can you give me a status update on this pull request so that we can continue to work on it or get it out?

Let me know and we'll go from there.

Have a fantastic day the both of you.

Archetipo95 commented 3 months ago

@jonniebigodes I did the suggestions that @ludovicobesana made and I'm done with this Pull Request for now. :)

ludovicobesana commented 3 months ago

Hi @jonniebigodes if @Archetipo95 has resolved all the points and reviewed the other files I think that we can merge it 🚀

jonniebigodes commented 3 months ago

@Archetipo95, I appreciate you following up with me on this, and I will merge this so we can get it published.

One small thing to take care of, @Archetipo95. If you're ok with it, can you message me directly (same username) on our Discord Server so that I can follow up with you on this pull request?

@ludovicobesana cannot thank you enough for your time in getting this proofread 🙇

Hope both of you have a great day.

Stay safe