search

chromaui / storybook-addon-pseudo-states

CSS pseudo-classes for Storybook
MIT License
88 stars 28 forks source link

Remove optional chaining #52

Closed filipw01 closed 1 year ago

filipw01 commented 1 year ago

Closes #48

You can test by changing

.storybook/main.js

-  core: {
-    builder: "webpack5",
-  },

package.json

-    "build:storybook": "build-storybook",
+    "build:storybook": "NODE_OPTIONS=--openssl-legacy-provider build-storybook",

I'm definitely for changing it back to optional chaining in 2.0

filipw01 commented 1 year ago

Just to give more context, this happens because webpack 4 doesn't support optional chaining. The workaround is to use webpack 5 or vite builder or upgrade to storybook 7 (currently in beta)

riotrah commented 1 year ago

@JonathanKolnik Can this please be merged?

JonathanKolnik commented 1 year ago

@riotrah sorry for the delay, @ghengeveld to the rescue! Thanks again everyone 😄

github-actions[bot] commented 1 year ago

:rocket: PR was released in v2.0.0-next.2 :rocket: