search

chromaui / storybook-addon-pseudo-states

CSS pseudo-classes for Storybook
MIT License
89 stars 28 forks source link

Remove redundant Regex negative lookbehind #67

Closed filipw01 closed 1 year ago

filipw01 commented 1 year ago

Closes: #66

filipw01 commented 1 year ago

@valentinpalkovic I see you added this negative lookbehind that I'm removing now. Do you remember why you added it, maybe I'm missing some edge case

@ghengeveld Could you review as well?

valentinpalkovic commented 1 year ago

Honestly, I don't remember! :/

JReinhold commented 1 year ago

I'm hesitant to merge this until tests have passed. I don't know why CI didn't trigger here. Could you create a non-content commit to hopefully trigger the CI?

filipw01 commented 1 year ago

All tests are passing locally, but I don't know why the CI doesn't trigger here 😕

filipw01 commented 1 year ago

@ghengeveld Why was this closed? Is it because next was merged into main? Should I reopen this, but with main branch as base instead of next