Issue #125: ColorValue object

[jimmysong]

Issue #125: ColorValue object Issue #29: Unit Tests Issue #105: System and Integration Testing

ColorValue is now an object that holds data about a colorvalue. It includes:

• reference to the ColorDefinition
• actual value of the color
• label, if any

There are multiple subclasses, of which SimpleColorValue is the one used everywhere.

AssetValue is now an object that holds data about an assetvalue. It includes:

• reference to the AssetDefinition
• actual value of the asset

There is one main subclass, AdditiveAssetValue which is used everywhere.

ColorTarget and AssetTarget correspond to targets of various TxSpecs.

• created colorvalue.py
• added unit tests for colorvalue.py
• refactored colordef.py to use SimpleColorValue
• created ColorTarget (holds address and ColorValue) in txspec
• changed BasicTxSpec to use AssetTarget
• changed SimpleOperationalTxSpec to use ColorTarget
• added unit tests for txspec.py
• added unit tests for blockchain.py
• refactored some of txcons
• got rid of is_monoasset and use is_monocolor exclusively
• got rid of unused is_uncolored
• added unit tests for txcons.py
• fixed unit tests for txdb.py
• moved asset.py and test_asset.py to coloredcoinlib
• changed wallet_controller to use the new AssetTarget
• added unit tests for wallet_controller
• Fixed some bugs in builder.py, particularly AidedColorDataBuilder
• Removed gt for comparable mixin since it's defined in the two subclasses
• Fixed explorer.py to use the BASE_URL
• Removed from store.py get_persistent_dict which nothing was using
• added test_builder, test_store, test_toposort
• Now covers everything except about 5 lines in all of coloredcoinlib
• added tests for services/*.py
• added tests for wallet_model
• added tests for p2ptrade/*.py
• changed p2ptrade to use ColorTarget and ColorValue

[jimmysong]

This is a ridiculously long checkin, in large part because I've done a good chunk of issue #29 and issue #105 as well. I'm not sure I got the assetvalue to colorvalue transition correct and I'm not sure whether unit was supposed to stay in AssetDefinition or put up further into ColorDefinition, but here's my effort after 35 hours or so. I'm afraid waiting any longer would have way too many merge conflicts to be able to manage effectively.

[amidvidy]

would it be possible to break this up into a few more granular commits?

[jimmysong]

It'll take me a few hours at least. It's up to killerstorm to decide if it's worth the time.

[arichnad]

Any update on this pull request? Thanks.

[killerstorm]

Jimmy will update p2ptrade too. Size of this pull request is not a problem, as I'm not going to discuss each individual part of it anyway.

We'll merge it after p2ptrade works, then further refactoring, if necessary, will go as separate tasks.

[killerstorm]

Just to clarify, there is a lot of refactoring ahead, so I'm not too concerned about quality of commits. After we'll finish with major refactoring I'll pay more attention to code reviews.

[jimmysong]

p2p should work now. I've added p2p unit tests (it includes testing the threaded stuff!).

We should have pretty close to 100% statement coverage for ngcccbase and coloredcoinlib. ui is not something I've touched yet.

[killerstorm]

I think we'll rewrite the parts responsible for ui <-> wallet interaction, so unit testing it is kinda pointless.