Html replacement And Multiple instaFilta on one page support

chromawoods / instaFilta

jQuery plugin for performing in-page filtering

MIT License

42 stars 12 forks source link

Html replacement And Multiple instaFilta on one page support #1

Closed jaapjanfrans closed 9 years ago

jaapjanfrans commented 9 years ago

Hi!

I've updated the plugin with the ability to:

replace the html of a target item instead of it's text. This prevents any html elements inside the item to be stripped
replacement of html only occurs when text should be highlighted

I've also added ignores for intellij idea to the gitignore files

Let me know if you think these are useful additions to you plugin. Thanks for creating it!

Kind regards, Jaap-Jan

chromawoods commented 9 years ago

Hi Jaap-Jan!

Thanks for your contribution. At a glance it looks fine, but I will look at it in more detail in the next few days (I hope) and then let you know. Just let me know if you have any other feature requests. :)

Best Regards /Andreas

jaapjanfrans commented 9 years ago

Hi Andreas,

Great, I'll await your review :-)

kind regards, Jaap-Jan

jaapjanfrans commented 9 years ago

I've added another feature, support for multiple filters on 1 page.

In my particular use case I had different sections, each with their own filter text input. I've added support for this and introduced a new setting: scope.

By defining a scope element that acts as a container for both the text input and the targets, we can create a scope in which instaFilta filters only those targets belonging to the text input in that particular container.

I've also update the readme file with the scope setting and a use case example at the bottom of the page.

Let me know what you think!

chromawoods commented 9 years ago

I will go ahead and merge your changes. However, I have a couple of minor stylistic tweaks that I would like to make first. This is actually the first pull request that I have ever handled, so I'm a bit unsure what the best practice is: Should I ask you to make the tweaks before I merge, or would it be ok if I merged your changes as it is and then perform the tweaks afterwards?

jaapjanfrans commented 9 years ago

I'd say go ahead and merge and make the tweaks afterwards.

chromawoods commented 9 years ago

It has been done. Again, thanks for contributing! /Andreas

jaapjanfrans commented 9 years ago

Great, glad I could add someting to instaFilta. And thank you again for creating an awesome plugin :-)

Jaap-Jan Frans

Developer of Web and Java apps

E: jaapjan@gmail.com

W: * http://jaap-janfrans.nl http://nl.linkedin.com/in/jaapjanfrans LinkedIn http://nl.linkedin.com/in/jaapjanfrans http://twitter.com/jaapjanfrans Twitter http://twitter.com/jaapjanfrans http://twitter.com/jaapjanfrans http://twitter.com/jaapjanfransP *Please consider the environment before printing this email

2014-12-15 21:47 GMT+01:00 Andreas Larsson notifications@github.com:

It has been done. Again, thanks for contributing! /Andreas

— Reply to this email directly or view it on GitHub https://github.com/chromawoods/instaFilta/pull/1#issuecomment-67062711.