search

chromawoods / instaFilta

jQuery plugin for performing in-page filtering
MIT License
42 stars 12 forks source link

Parent element #17

Closed durasj closed 8 years ago

durasj commented 9 years ago

I am trying to implement your filter and it is quite good but so far unusable for me. The problem is element with text is not my entire element but only child with text. It would be really good if I could choose closest parent element which should be hidden. I will be probably implement it myself and do a PR.

chromawoods commented 9 years ago

Not enitirely sure what you mean. Would it be possible for you to use sections for this? Something like this:

<parent class="instafilta-section">
  <child class="instafilta-target">searchable text</child>
  Some other content
  Some other content
  Some other content
</parent>
durasj commented 9 years ago

Yes, but I am already using sections. I would be better if I could choose if insta should hide element which was found or some parent (jquery closest function). Unfortunately, I decided to write my own search functionality specific for my use, because I think it would take me more time to modify your code.

chromawoods commented 9 years ago

I see. I am currently developing v2 of the plugin and I will make sure to include your feature in it. Not sure when that will be completed, though. :)

durasj commented 9 years ago

Thank you! It does not matter. I already implemented my own code but I will be willing to adapt your next version if I see you are maintaing this project. You are probably better coder than I am and less things I have to worry about ... ;)

Mgamerz commented 8 years ago

I too am looking for something to hide a containing parent element of the unmatched item. This library looked so promising compared to others... :(

chromawoods commented 8 years ago

@Mgamerz check out the instaFilta2 project, it has support for this.

durasj commented 8 years ago

Link to the instaFilta2 (separate repository, not a branch): https://github.com/chromawoods/instaFilta2