chromebrew / crew-launcher

9 stars 4 forks source link

Crew-Launcher: Cannot add Firefox using package name or .desktop file #14

Open aghebert opened 2 years ago

aghebert commented 2 years ago

Tried to add firefox installed from chromebrew using crew-launcher; crew-launcher new firefox The browser pops up asking "add to launcher", which adds a firefox icon to the chromeOS launcher. However, when the launcher icon is clicked, firefox does not start.

So I tried to add firefox using the .desktop file, but it kept saying firefox is not installed.

Screenshot 2021-10-18 14 27 20

Versions and system information

chromebrew: 1.17.5

ChromeOS: CHROMEOS_RELEASE_BOARD=octopus-signed-mp-v31keys CHROMEOS_RELEASE_BRANCH_NUMBER=77 CHROMEOS_RELEASE_BUILDER_PATH=octopus-release/R93-14092.77.0 CHROMEOS_RELEASE_BUILD_NUMBER=14092 CHROMEOS_RELEASE_BUILD_TYPE=Official Build CHROMEOS_RELEASE_CHROME_MILESTONE=93 CHROMEOS_RELEASE_DESCRIPTION=14092.77.0 (Official Build) stable-channel octopus CHROMEOS_RELEASE_KEYSET=mp-v31 CHROMEOS_RELEASE_NAME=Chrome OS CHROMEOS_RELEASE_PATCH_NUMBER=0 CHROMEOS_RELEASE_TRACK=stable-channel CHROMEOS_RELEASE_UNIBUILD=1 CHROMEOS_RELEASE_VERSION=14092.77.0 DEVICETYPE=CHROMEBOOK GOOGLE_RELEASE=14092.77.0

Model: Acer Spin 512

Architecture: x86_64

uberhacker commented 2 years ago

@aghebert: Does firefox start in your crosh shell? If not, that could be your issue.

aghebert commented 2 years ago

Yes, it works. If I start Firefox using firefox in crosh shell, it will start normally.

supechicken commented 2 years ago

Could you try the steps listed in https://github.com/supechicken666/pwashortcut/blob/stable/installer.html after crew-launcher new firefox?

Yes, it works. If I start Firefox using firefox, it will start normally.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/skycocker/chromebrew/issues/6314#issuecomment-946097424, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARQDSSNQEWD4ZEVD65IJ3N3UHRYXDANCNFSM5GHJWWIA .

aghebert commented 2 years ago

Those instructions don't work. I get this error when I click the firefox shortcut;

Screenshot 2021-10-29 11 01 02

I checked to make sure the server was running as well.

supechicken commented 2 years ago

Since the crew-launcher new firefox command created a new profile for firefox, you need to install the shortcut once more (also the pwa) and use the new shortcut in the launcher (make sure that you are using the new shortcut :) )

aghebert commented 2 years ago

I'm not sure I understand. I removed the old Firefox shortcut from crew-launcher, created a new Firefox shortcut using crew-launcher, and clicked on the new shortcut. What am I missing?

uberhacker commented 2 years ago

@aghebert: Do you have any ad or popup blocker extensions enabled in your browser?

supechicken commented 2 years ago

I'm not sure I understand. I removed the old Firefox shortcut from crew-launcher, created a new Firefox shortcut using crew-launcher, and clicked on the new shortcut. What am I missing?

Your steps are correct, could you provide the output of crew-launcher uuid firefox?

aghebert commented 2 years ago
crew-launcher uuid firefox
15f6f48b-87f5-4664-bed7-916e78d08795
aghebert commented 2 years ago

Update! Looks like i have leftover shortcut icons. I didn't realize this and was clicking on an older firefox shortcut. The newer one works!

EDIT: I take it back, seems like this shortcut is one and done. Can't get it to work after pinning it in the bar. Seems to launch a window, but that closes almost instantly and firefox does not start.

supechicken commented 2 years ago

Update! Looks like i have leftover shortcut icons. I didn't realize this and was clicking on an older firefox shortcut. The newer one works!

EDIT: I take it back, seems like this shortcut is one and done. Can't get it to work after pinning it in the bar. Seems to launch a window, but that closes almost instantly and firefox does not start.

If the window closes immediately, we can confirm the shortcut itself is working :) Seems that firefox is trying use Wayland to display instead of x11, could you try the following:

GDK_DISPLAY=x11
startsommelier
crew-launcher stop && crew-launcher start

The shortcut should work now

uberhacker commented 2 years ago

@aghebert: I just tested the new edge package and it works fine for me. Is your server running? What is the output of crew-launcher status? If not, run crew-launcher start and try to load firefox from the launcher. If this works then it might be a good idea to add crew-launcher start in your ~/.bashrc so the server starts when you login. EDIT: Actually, you don't need to add crew-launcher start to ~/.bashrc since /usr/local/etc/env.d/crew_launcher already does this for you.

zeglol1234 commented 1 year ago

Can somebody tell me how to use --display, im lost here

Zopolis4 commented 1 month ago

This issue is probably better suited for the crew-launcher repo, right? Should someone transfer it?