search

chromedp / cdproto

Package cdproto contains the generated commands, types, and events for the Chrome DevTools Protocol domains.
MIT License
149 stars 54 forks source link

Latest update broke chromedp #1

Closed frioux closed 5 years ago

frioux commented 5 years ago

8d5e1d04ce19b7b3e61493418de25a281de3709d causes https://github.com/chromedp/chromedp/issues/285. My guess is that we either need to leave a tombstone type in place or update chromedp, though clearly this is a breaking change that could break other code too.

mvdan commented 5 years ago

The root of the problem isn't here; the change in question was automated. All users of cdproto should pin a specific version of it, which chromedp is already doing in the master branch. Let's keep discussion in the chromedp issue.