chromelyapps / Chromely

Build Cross Platform HTML Desktop Apps on .NET using native GUI, HTML5, JavaScript, CSS, Owin, AspNetCore (MVC, RazorPages, Blazor)
MIT License
2.98k stars 279 forks source link

CommandAction Exception details not in log file #256

Closed xjfnet closed 3 years ago

xjfnet commented 3 years ago

.csproj

    <ItemGroup>
            <FrameworkReference Include="Microsoft.AspNetCore.App" />
    </ItemGroup>

    <ItemGroup>
        <PackageReference Include="CefSharp.Common" Version="83.4.20" />
        <PackageReference Include="Chromely.CefSharp" Version="5.1.83" />
        <PackageReference Include="FirebirdSql.Data.FirebirdClient" Version="7.5.0" />
        <PackageReference Include="linq2db.Access" Version="3.1.6" />
        <PackageReference Include="LiteDB" Version="5.0.9" />
        <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="3.1.9" />
        <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="3.1.9" />
        <PackageReference Include="Microsoft.Extensions.Logging.Console" Version="3.1.9" />
        <PackageReference Include="Npoi.Mapper" Version="3.5.1" />
        <PackageReference Include="Serilog.Extensions.Logging.File" Version="2.0.0" />
        <PackageReference Include="System.Text.Json" Version="4.7.2" />
    </ItemGroup>

ChromelyApp

    public class CustomChromelyApp : ChromelyFramelessApp
    {
        public override void ConfigureServices(ServiceCollection services)
        {
            base.ConfigureServices(services);
            services.AddLogging(configure => configure.AddConsole());
            services.AddLogging(configure => configure.AddFile("Logs/serilog-{Date}.txt"));

when a Exception occurs in a CommandAction, i can't see the details in log file

2020-11-01T12:52:26.3346465+08:00  [ERR] DefaultCommandTaskRunner:Run (0a38aeb3)

https://github.com/chromelyapps/Chromely/blob/9b07200e0533d584c76ba4dbdf66132679ccb519/src/Chromely.Core/Defaults/DefaultCommandTaskRunner.cs#L51

according to Microsoft.Extensions.Logging.LoggerExtensions 3.1.5 source code, the two parameters should be exchanged

Logger.Instance.Log.LogError(exception, "DefaultCommandTaskRunner:Run");