Closed donotcodeit closed 3 years ago
I also can confirm that process will not be killed when exception happens:
@donotcodeit Please is this still happening?
@mattkol i've just tested it - yes, it is still happening.
Exception happening in a NativeHostBase.cs
. Do we really need to kill UI process after exiting out of message loop?
@donotcodeit looks like it was fixing an issue that was reported. I really do not think it is needed, but not a bad safeguard. I removed from the background thread and also checked to ensure that the process id is valid. I am sure 99.9% of the time that will not be called.
https://github.com/chromelyapps/Chromely/commit/d05b574f1c4eacfefc827ebb7fc4f6e1c6548b5c
@mattkol I've tested - it's OK now. Thanks!
There's minimum reproduceable app: https://github.com/donotcodeit/ChromelyMin51/tree/repro/error-on-close
Steps to reproduce:
Exception is a little transient, probably because it happens inside of
Task.Run
, but I was able to reproduce it every 2 out of 3 times.I didn't tested it in any mode but Frameless. Exception will be thrown in
NativeHostBase
, so it is probably not related only to Frameless.